[libcxx-commits] [PATCH] D99691: [libcxx] adjusts formatting rules

Thu Apr 8 11:35:22 PDT 2021

zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

> I started working on SpacesInAngles: Leave option for clang-format. If that's accepted, we could use this option together with Standard: Latest (or c++20, btw, Cpp11 is deprecated). I need to check that there's nothing else apart angle brackets that may break pre-C++20 code.

Yay, that would be awesome.

> Please. I find comments asking for > > to be turned into >>, and friends, exhausting.

Sorry :P

> Is it possible to increase the length of lines as enforced by clang-format? Libc++ tends to have a lot of verbose identifiers and macros, and it really helps readability if that doesn't cause us to break lines all around the place.

We can use `ColumnLimit`. Or `ColumnLimit: 0` to ignore it. I don't have a preference one way or another (in terms of leaving it, changing it, or removing it).

---

I think we should land this, or update the column limit and land this (though, I'd argue that should be a different patch). We can (and should) discuss the other things (such as deprecating C++03) in another place. This is a small, contained, easy, nfc patch. Let's just get it in.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99691/new/

https://reviews.llvm.org/D99691