[libcxx-commits] [PATCH] D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types.

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 8 11:16:38 PDT 2021


zoecarver added inline comments.


================
Comment at: libcxx/include/memory:3257
 <
-    !is_array<_Yp>::value &&
     is_convertible<typename unique_ptr<_Yp, _Dp>::pointer,
----------------
Interestingly enough, updating the enable_if here wasn't required to get the tests to pass, I think because of implicit conversion to shared_ptr before the assignment happens. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80882/new/

https://reviews.llvm.org/D80882



More information about the libcxx-commits mailing list