[libcxx-commits] [PATCH] D90999: [libc++] Implements ranges::enable_borrowed_range

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/ranges/range.range/enable_borrowed_range.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Mordante wrote:
> cjdb wrote:
> > Please change to `enable_borrowed_range.pass.cpp` (we've agreed in other patches to move away from `.compile`). Same with other files (this is just the first I noticed).
> In the past had requests to rename test to use `.compile`. I asked for a policy on its usage on Discord, depending on the answer there I'll keep this name or rename the file.
As discussed on Discord we can keep compile only tests `.compile`. To future-proof them they shouldn't contain a `main`. So I'll update the `.compile` tests to have no `main`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90999/new/

https://reviews.llvm.org/D90999