[libcxx-commits] [PATCH] D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set

Kristina Bessonova via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 7 03:30:17 PDT 2021


krisb created this revision.
krisb added reviewers: ldionne, howard.hinnant.
krisb requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The debug mode tests for map/set iterators construct empty containers,
making the code after the first increment meaningless.
It's never executed since the tests exit earlier.

It doesn't seem to be intentional, so the patch makes the tests to construct
containers that include an element.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100029

Files:
  libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_9.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_9.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_9.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_9.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_iterators_9.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_9.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100029.335770.patch
Type: text/x-patch
Size: 7102 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210407/05b8ddef/attachment.bin>


More information about the libcxx-commits mailing list