[libcxx-commits] [PATCH] D100005: [libc++] Use the more precise constructor for char_type in std::num_get::do_get.

Yichen Yan via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 7 01:02:10 PDT 2021


oraluben added a comment.

In D100005#2673341 <https://reviews.llvm.org/D100005#2673341>, @curdeius wrote:

> Could you please minimize your example (if possible) and make a test out of it, please?

This is already the minimal version I've got. Will update the test later.

> Have you, by any chance, found the part of the standard that requires the standard library to accept it?

Not really, I think this should be revised based on two facts:

1. delete any of char/unsigned int constructors will make the code accepted by libc++;
2. the code works fine with libstdc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100005/new/

https://reviews.llvm.org/D100005



More information about the libcxx-commits mailing list