[libcxx-commits] [PATCH] D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming

Tue Apr 6 12:54:48 PDT 2021

ldionne added a comment.

In D96523#2666706 <https://reviews.llvm.org/D96523#2666706>, @EricWF wrote:

> Here is one regression I've found so far:
>
> https://godbolt.org/z/sahqsqarb

Thanks for the find. Did you find anything else?

> I'm a bit worried about some of the tests that were deleted. Not the ones for extensions, but some of the ones added to prevent regressions with SFINAE.

Which specific tests are you worried about? I looked and I think the only ones I removed were related to libc++ extensions which do not exist after this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96523/new/

https://reviews.llvm.org/D96523