[libcxx-commits] [PATCH] D99309: [libc++] Header inclusion tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

This LGTM with some comments. Huge thanks for writing this. You don't have to re-review if you apply my comments and other reviewer's outstanding comments:

- The section on `Adding a new header TODO` should be updated in `Contributing.rst`.
- Use `.compile.pass.cpp` BUT don't define `main()` - this way there's no possibility for confusion on whether the test should run or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99309/new/

https://reviews.llvm.org/D99309