[libcxx-commits] [PATCH] D99932: [libcxx] Fix the type attribute for the default_searcher template

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D99932#2670597 <https://reviews.llvm.org/D99932#2670597>, @curdeius wrote:

> Could you fix the same thing in `experimental/functional` as well when you're here?

Sure

> Also, shouldn't `boyer_moore_searcher` and `boyer_moore_horspool_searcher` (in `<experimental/functional>`) and `in_place_index_t` (in `<utility>`) be affected as well?

Yes, so it seems. FWIW the experimental library can only be built as a static library, so that's not tested in the current CI setup (but I'm experimenting with extending testing with a static library case as well, which would increase coverage over a few more testcases, and narrow down a number of the existing xfails), but in a static library configuration on windows, both `_LIBCPP_TYPE_VIS` and `_LIBCPP_TEMPLATE_VIS` expand to nothing at all, so the distinction isn't quite as easy to pick up on. And I didn't find any test with an XFAIL regarding `in_place_index_t`, but let's see what another round through the CI says...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99932/new/

https://reviews.llvm.org/D99932