[libcxx-commits] [PATCH] D99789: [libc++] Add fallback standard flags and normalize corresponding feature.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

@ldionne, I'd like to hear you input on the changes in params.py. At least just to check that I haven't done anything stupid (given my lack of knowledge of lit and related stuff).

Apart from that, I start thinking of the plan for adding new standard, if anyone sees other points, please LMK.

Example: adding c++2c, c++23 (before: c++2b) released:

- In `libcxx/utils/libcxx/test/params.py`:
  - Change c++2b to c++23, add c++2c to `_allStandards`.
  - Add `'c++23': 'c++2b'` to `_standardFallback` dictionary.
- Change c++2b to c++23 and add c++2c to `std_dialects` list in `libcxx/utils/generate_feature_test_macro_components.py`.
- Add `C++2c` CI job to `libcxx/utils/ci/buildkite-pipeline.yml`.
- Add `generic-cxx2c` to `libcxx/utils/ci/run-buildbot`.
- Add `libcxx/cmake/caches/Generic-cxx2c.cmake` CMake cache file.
- [Optionally] Add new feature-test macros `libcxx/utils/generate_feature_test_macro_components.py`.

- In `libcxx/include/__config`, bump `_LIBCPP_STD_VER` for C++2b and add a new value for C++2c.
- In `libcxx/test/support/test_macros.h`, set `TEST_STD_VER` to `23` for C++2b and to `99` for C++2c.
- In `libcxx/test/support/msvc_stdlib_force_include.h`, bump `TEST_STD_VER` for MSVC.

- In `libcxx/CMakeLists.txt`, use `CXX_STANDARD 23` (or higher?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99789/new/

https://reviews.llvm.org/D99789