[libcxx-commits] [PATCH] D99932: [libcxx] Fix the type attribute for the default_searcher template

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Use `_LIBCPP_TEMPLATE_VIS` instead of `_LIBCPP_TYPE_VIS` for a template
class.

This fixes the nodiscard_extensions.pass.cpp testcase when built
in MSVC/DLL configurations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99932

Files:
  libcxx/include/functional
  libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp


Index: libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp
===================================================================
--- libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp
+++ libcxx/test/libcxx/diagnostics/nodiscard_extensions.pass.cpp
@@ -18,8 +18,6 @@
 // UNSUPPORTED: apple-clang-9
 // UNSUPPORTED: gcc-5
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 // All entities to which libc++ applies [[nodiscard]] as an extension should
 // be tested here and in nodiscard_extensions.fail.cpp. They should also
 // be listed in `UsingLibcxx.rst` in the documentation for the extension.
Index: libcxx/include/functional
===================================================================
--- libcxx/include/functional
+++ libcxx/include/functional
@@ -3184,7 +3184,7 @@
 
 // default searcher
 template<class _ForwardIterator, class _BinaryPredicate = equal_to<>>
-class _LIBCPP_TYPE_VIS default_searcher {
+class _LIBCPP_TEMPLATE_VIS default_searcher {
 public:
     _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17
     default_searcher(_ForwardIterator __f, _ForwardIterator __l,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99932.335435.patch
Type: text/x-patch
Size: 1104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210406/db616e26/attachment.bin>