[libcxx-commits] [PATCH] D99309: [libc++] Header inclusion tests

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius accepted this revision as: curdeius.
curdeius added a comment.

LGTM % nit and the pass/compile.pass naming decision.



================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:114-115
+        return ''
+    modern_versions = ["03", "11", "14", "17", "20"]
+    return 'TEST_STD_VER > {} && '.format(max(i for i in modern_versions if i < v))
+
----------------
Nit: remove `modern_`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99309/new/

https://reviews.llvm.org/D99309