[libcxx-commits] [PATCH] D99928: [libcxx] [test] Use dedicated types for the invocable concept tests for multiple overloads
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 6 00:44:02 PDT 2021
curdeius added a comment.
I think that now we test less than before. Precisely, this code tested before that e.g. one could invoke `f(double)` with a `float` argument.
I'd like to see:
struct DA : A {};
struct DB : B {};
static_assert(std::regular_invocable<multiple_overloads&, multiple_overloads::DA>);
static_assert(std::regular_invocable<multiple_overloads&, multiple_overloads::DB>);
(and the same for `std::invocable`)
Apart from that, it looks good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99928/new/
https://reviews.llvm.org/D99928
More information about the libcxx-commits
mailing list