[libcxx-commits] [PATCH] D99805: [libcxx] adds __cpp_lib_concepts feature-test macro

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 5 23:54:51 PDT 2021


curdeius added a comment.

In D99805#2670041 <https://reviews.llvm.org/D99805#2670041>, @cjdb wrote:

> @zoecarver @curdeius this patch now changes a feature-test macro, so I don't think it can be NFC. Are you okay with that?

If there's doubt, don't mark it as NFC.
Adding NFC when it's not NFC would make more harm than not adding NFC when it really is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99805/new/

https://reviews.llvm.org/D99805



More information about the libcxx-commits mailing list