[libcxx-commits] [PATCH] D99178: [libcxx] Disable c++experimental by default in DLL builds

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D99178#2669529 <https://reviews.llvm.org/D99178#2669529>, @ldionne wrote:

> I'd like to suggest that we instead add a `libcxx/cmake/caches/Windows.cmake` file that contains those defaults. This would move us towards removing platform-specific knowledge from the CMake instead of towards it. WDYT?

Can you elaborate on which defaults you'd like to have there? While having example setups as cmake caches can be useful, use of the cmake caches is very much optional, so logic for disabling it by default needs to be in the main CMakeLists.txt instead of in an optional cmake cache to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99178/new/

https://reviews.llvm.org/D99178