[libcxx-commits] [PATCH] D99178: [libcxx] Disable c++experimental by default in DLL builds

Mon Apr 5 12:22:22 PDT 2021

mstorsjo added a comment.

In D99178#2668045 <https://reviews.llvm.org/D99178#2668045>, @Mordante wrote:

> LGTM modulo a small suggestion. If you don't want to address that suggestion, please rebase to trigger a CI run. I'd like to see it builds without issues before giving my approval.

Now it has a green CI checkmark. As the Windows CI isn't merged yet, this patch didn't run a windows configuration though (but I ran D99093 <https://reviews.llvm.org/D99093> through CI just now as well, and that one also is green) - and with this patch applied, one can just remove one case of `-DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=NO` from the CI config, which gets set implicitly instead. (I've run a combination of these two through CI elsewhere too.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99178/new/

https://reviews.llvm.org/D99178