[libcxx-commits] [PATCH] D99862: [libc++] [CI] Validate the output of the generated scripts.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 3 inline comments as done.
Mordante added a comment.

I addressed the review comments and the final test build is running.



================
Comment at: libcxx/utils/ci/run-buildbot:138
+    echo "+++ Checking output of utils/generate_feature_test_macro_components.py"
+    # We need to set --extensions so that clang-format checks extensionless files.
+    mkdir -p ${BUILD_DIR}
----------------
curdeius wrote:
> Quuxplusone wrote:
> > curdeius wrote:
> > > Copy-pasta mistake. Please remove this comment.
> > How about throwing in the other `libcxx/utils/` generators here while you're at it?
> > `python3 libcxx/utils/generate_header_tests.py`
> > This will also give me an obvious place to add `generate_header_inclusion_tests.py` once we get some reviews on D99309.
> +1
Thanks for the suggestion!
I added `libcxx/utils/generate_header_tests.py`. 
The validation of the output of `libcxx/utils/generate_abi_list.py` has already been added to the proper CI jobs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99862/new/

https://reviews.llvm.org/D99862