[libcxx-commits] [PATCH] D99309: [libc++] Header inclusion tests

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 5 05:02:45 PDT 2021


curdeius added a comment.

In D99309#2668368 <https://reviews.llvm.org/D99309#2668368>, @Quuxplusone wrote:

> Add missing trailing newline.
> Fix `TEST_STD_VER == 11` -> `TEST_STD_VER >= 11`. (Anyone got a better "C++0x or later" check?)

Why not just `TEST_STD_VER > 3`? Cf. https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/test_macros.h#L95.
This would remove special casing for v==11.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99309/new/

https://reviews.llvm.org/D99309



More information about the libcxx-commits mailing list