[libcxx-commits] [PATCH] D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 2 inline comments as not done.
cjdb added inline comments.


================
Comment at: libcxx/include/iterator:492
+requires __is_primary_template<iterator_traits<_Ip>>::value &&
+         (__has_member_difference_type<_Ip> || __has_integral_minus<_Ip>)
+struct __extract_iter_difference_t<_Ip> {
----------------
miscco wrote:
> miscco wrote:
> > The `__has_integral_minus` Is not obvious should have add a comment?
> Please disregard, read the other patch
I can't find your comment anywhere else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99863/new/

https://reviews.llvm.org/D99863