[libcxx-commits] [PATCH] D99862: [libc++] Validate the output of generate_feature_test_macro_components.py

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:138
+    echo "+++ Checking output of utils/generate_feature_test_macro_components.py"
+    # We need to set --extensions so that clang-format checks extensionless files.
+    mkdir -p ${BUILD_DIR}
----------------
curdeius wrote:
> Copy-pasta mistake. Please remove this comment.
How about throwing in the other `libcxx/utils/` generators here while you're at it?
`python3 libcxx/utils/generate_header_tests.py`
This will also give me an obvious place to add `generate_header_inclusion_tests.py` once we get some reviews on D99309.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99862/new/

https://reviews.llvm.org/D99862