[libcxx-commits] [PATCH] D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 4 12:17:21 PDT 2021


Mordante added inline comments.


================
Comment at: libcxx/include/iterator:556
+
+// indirectly_­readable_­traits<R[I]>::value_­type if `iterator_­traits<R[I]>` names a specialization
+// generated from the primary template, and
----------------
For consistency, please add backticks around `indirectly_­readable_­traits<R[I]>::value_­type`.


================
Comment at: libcxx/include/iterator:565
+
+// iterator_­traits<R[I]>::value_­type otherwise.
+template<class _Ip>
----------------
For consistency, please add backticks around `iterator_­traits<R[I]>::value_­type`.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/incrementable.traits/iter_difference_t.fail.cpp:19
+using fails1 = std::iter_difference_t<void>;
+// expected-error at iterator:* {{no type named 'difference_type' in 'std::iterator_traits<void>'}}
+
----------------
Why not use a specific offset like `expected-errror at -1`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99863/new/

https://reviews.llvm.org/D99863



More information about the libcxx-commits mailing list