[libcxx-commits] [PATCH] D99178: [libcxx] Disable c++experimental by default in DLL builds

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 4 09:57:00 PDT 2021


mstorsjo added inline comments.


================
Comment at: libcxx/CMakeLists.txt:416
+                      " static library, while the headers signal dllimport"
+                      " linkage.")
+endif()
----------------
Mordante wrote:
> Nice. One suggestion "Windows, as the" -> "Windows. The".
Good point, will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99178/new/

https://reviews.llvm.org/D99178



More information about the libcxx-commits mailing list