[libcxx-commits] [PATCH] D99615: [libc++] Improve generate_feature_test_macro_components.py.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:56-59
+#                   It's possible to use the `AVAILABILITY_DISABLE` macros of
+#                   <__availability> since it defines libc++ specific macros,
+#                   that aren't defined by other C++ standard library
+#                   implementations.
----------------
Wonky English grammar here; also, this logic applies equally well to //any// libc++ header (that libc++ headers define things that aren't defined by other library implementations).
I think you should add a TODO and come back to this; i.e., take my suggested fix verbatim.
These macros were all introduced in @ldionne's D94983, btw.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99615/new/

https://reviews.llvm.org/D99615