[libcxx-commits] [PATCH] D99615: [libc++] Improve generate_feature_test_macro_components.py.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks a lot for your review comments @Quuxplusone, it really helps to get the documentation is a better shape!



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:42-58
+# test_suite_guard  An optional string field. When this field is provided,
+#                   `libcxx_guard` must also be provided. This field is used
+#                   only to generate the unit tests for the feature-test macros.
+#                   It must never depend on anything defined in <__config>,
+#                   but it may depend on
+#                    * macros defined by the compiler itself,
+#                    * macros generated by CMake, or
----------------
Quuxplusone wrote:
> I've taken the liberty of providing a suggested edit I'd be happy with. I think anything close to this is probably OK.
I disagree with the TODO. I think using `<__availability>` is fine. I'll update the patch with the reason why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99615/new/

https://reviews.llvm.org/D99615