[libcxx-commits] [PATCH] D99691: [libcxx] adjusts formatting rules

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D99691#2665215 <https://reviews.llvm.org/D99691#2665215>, @ldionne wrote:

> I think this is great, with nitpicks. I've actually been thinking that we should make the clang-format CI job a hard-failure, as that would greatly reduce the room for formatting related comments, which are often (although not always) a distraction.
>
> Even though we all have pet peeves and opinions w.r.t. formatting, I think we'll all be more productive and will have a easier time collaborating if we just agree on one style guide that can be applied mechanically. It's hard for everyone to make the transition, myself included (I love my style!), but I think it's the pragmatic way forward.

I'm really in favour if this. I've seen enough coding styles that I no longer care a lot about the exact style. The thing I care about is to have a tool to do the proper formatting for me.

Unfortunately there's a blocker to make clang-format a hard error. We need a solution to support multiple C++ version at least on a file basis. Using C++03 formatting will break valid C++20 code `auto str = u8"abc";` will become `auto str = u8 "abc";`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99691/new/

https://reviews.llvm.org/D99691