[libcxx-commits] [PATCH] D98750: Apply [[standalone_debug]] to some types in the STL.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.

I like this patch. It's targeted and fixes the problem it's aiming at well.

Debug information provides real value to our users. And while it might be ideal to fix the actual implementations so they contain less magic and generate better debug info, that's unrealistic given the nature of the standard library (which needs magic from time to time).

This patch LGTM. I don't think it precludes other improvements to the types as @ldionne was mentioning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98750/new/

https://reviews.llvm.org/D98750