[libcxx-commits] [PATCH] D99801: [libcxx] adds Microsoft/STL tests for P0898R3

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Seems fine to me, as long as
(1) @ldionne is okay with the licensing terms (and should they perhaps be repeated in the README?)
(2) running `./bin/llvm-lit ../libcxx/test/` picks up these tests and does the Right Thing with them



================
Comment at: libcxx/test/msvc-stl/README.md:10
+* LIT directives have been applied to all `test.pass.cpp` files.
+* A single `// clang-format off` has been added to each file underneath LIT directives.
+* Pragma directives disabling `-Wunknown-pragmas` (Clang, GCC) and `-Wdeprecated-volatile` (Clang)
----------------
You also added `// clang-format on` in some places. I recommend deleting it; these files will never be subjected to clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99801/new/

https://reviews.llvm.org/D99801