[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked an inline comment as done.
cjdb added a comment.

In D96477#2666439 <https://reviews.llvm.org/D96477#2666439>, @zoecarver wrote:

> This LGTM. I like these tests a lot better :)
>
> Only question: why do we need a separate test file for "subsumption" tests? WDYT about merging those into the "main" test file?

I plan to go back at some point and add subsumption tests for all concepts. I think there are quite a few that would benefit from being in their own source files for brevity's sake, and wanna keep that consistent.
Consider this a pilot?



================
Comment at: libcxx/include/concepts:402
+// [concept.predicate]
+template<class _Fn, class... _Args>
+concept predicate =
----------------
zoecarver wrote:
> Do we need to update the synopsis with these?
I added these in the very first `<concepts>` commit (which is different to how I'm doing things for `<iterator>` and `<ranges>`). Unless there's some divergence between synopsis and code that you're pointing out that I'm missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477