[libcxx-commits] [PATCH] D99768: [libcxx] [test] Make the condvar wait_for tests a bit more understandable. NFC.
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 1 15:13:03 PDT 2021
mstorsjo added inline comments.
================
Comment at: libcxx/test/std/thread/thread.condition/thread.condition.condvar/wait_for.pass.cpp:36
-int runs = 0;
+bool expect_timeout = false;
----------------
Quuxplusone wrote:
> Is there a reason we can't do `void f(bool expect_timeout)`?
I guess we could, although I'm not sure if that makes it significantly more readable...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99768/new/
https://reviews.llvm.org/D99768
More information about the libcxx-commits
mailing list