[libcxx-commits] [PATCH] D99641: [libcxx] [test] Fix invocable tests on Windows
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 1 09:20:21 PDT 2021
cjdb requested changes to this revision.
cjdb added a subscriber: ldionne.
cjdb added a comment.
This revision now requires changes to proceed.
In D99641#2663092 <https://reviews.llvm.org/D99641#2663092>, @mstorsjo wrote:
> Went with the simplest way forward, making the test less ambiguous, leaving testing for compiler correctness to some other testsuite.
Please do not do this, or at least wait for @ldionne to approve before submitting. Louis approved this test, and I believe he was aware of my intentions with the original comprehensiveness.
There's also the added problem that we're //removing// coverage in libc++ tests without evidence that it's been added elsewhere, but this is secondary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99641/new/
https://reviews.llvm.org/D99641
More information about the libcxx-commits
mailing list