[libcxx-commits] [PATCH] D88458: [CMake] Cache compiler-rt library results

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 30 11:04:04 PDT 2020


phosek added a comment.

In D88458#2304125 <https://reviews.llvm.org/D88458#2304125>, @ldionne wrote:

> In D88458#2302188 <https://reviews.llvm.org/D88458#2302188>, @phosek wrote:
>
>> In D88458#2302059 <https://reviews.llvm.org/D88458#2302059>, @compnerd wrote:
>>
>>> If we require LLVM for any of the projects, perhaps we should hoist the `HandleCompilerRT.cmake` into LLVM and avoid having to maintain the copy everywhere.
>>
>> That's the eventual plan but we haven't yet figured out how the sharing is going to work.
>
> What do you mean? Just `include(...)` the file from the various projects?

When migrating to monorepo, we discussed a plan to provide slices for individual projects. While these haven't been provided officially,  we already have these for our own purposes (e.g. https://llvm.googlesource.com/llvm-project/libcxx/) and they are used by projects like Chromium. A potential solution would be extend the machinery so that the content of `<llvm-project>/cmake/Modules` is copied into each slice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458



More information about the libcxx-commits mailing list