[libcxx-commits] [PATCH] D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D86704#2301405 <https://reviews.llvm.org/D86704#2301405>, @miyuki wrote:

> @ldionne, do you have any thoughts on how we might progress this forward?

Sorry for the radio silence -- I was working on something which should make this (and more) a lot easier to test.

I recently checked in CI configuration files that allow running tests under various configurations. I believe one way to test this external threading API would be to add a builder that tests this configuration. You can see the list of current configurations here: `libcxx/utils/ci/run-buildbot.sh`. Given this new setup where build bots are checked into the repo, I think adding a bot that test this configuration would be a good way of making sure this doesn't regress. What do you think?

Also, a meta question: Is there a reason why your platform can't simply provide the pthread or the C11 threading APIs, and libc++ has to provide this bridge instead? It would seem better for your platform to provide a standardized API instead, no? I'm trying to understand why the external threading API mode is useful (it feels like I've asked that before though, so just point me to the answer if that's the case).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86704/new/

https://reviews.llvm.org/D86704