[libcxx-commits] [PATCH] D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast added a comment.

@ldionne, does this patch look okay to you? In terms of changes being made for z/OS, it's mainly going to be:

- lack of LSB and BSD or GNU extension APIs,
- older UNIX conformance level,
- EBCDIC/ASCII mode support, and
- versioning for IEEE floating point.

I understand that a lot of context would be needed for the latter two, but I believe that the first two is not particularly special and introduces only the usual amount of maintenance burden.
Has it been a norm to request a full set of patches from the get-go before accepting patches that adjust for API differences?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87940/new/

https://reviews.llvm.org/D87940