[libcxx-commits] [PATCH] D88454: [CMake] Use -isystem flag to access libc++ headers

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 28 16:17:44 PDT 2020


phosek created this revision.
phosek added reviewers: beanz, ldionne.
Herald added subscribers: llvm-commits, libcxx-commits, dexonsmith, mgorny.
Herald added projects: libc++, LLVM.
Herald added a reviewer: libc++.
phosek requested review of this revision.

This is a partial revert of D62155 <https://reviews.llvm.org/D62155>. Rather than copying libc++ headers
into the build directory to be later overwritten by the final headers,
use -isystem flag to access libc++ headers during CMake checks. This
should address the occasional flake we've seen, especially on Windows
builders where CMake fails to overwrite __config with the final version.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88454

Files:
  libcxx/include/CMakeLists.txt
  llvm/runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88454.294823.patch
Type: text/x-patch
Size: 5564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200928/1f257f0c/attachment.bin>


More information about the libcxx-commits mailing list