[libcxx-commits] [PATCH] D88449: [libcxx] Don't pass -s to libtool

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: smeenai, ldionne.
Herald added subscribers: libcxx-commits, dexonsmith.
Herald added a project: libc++.
Herald added a reviewer: libc++.
phosek requested review of this revision.

This flag is the default in libtool on Darwin, and it's not supported
by llvm-libtool-darwin causing a build failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88449

Files:
  libcxx/utils/merge_archives.py


Index: libcxx/utils/merge_archives.py
===================================================================
--- libcxx/utils/merge_archives.py
+++ libcxx/utils/merge_archives.py
@@ -143,7 +143,7 @@
 
     if args.use_libtool:
         files = [f for f in files if not f.startswith('__.SYMDEF')]
-        execute_command_verbose([libtool_exe, '-static', '-o', args.output, '-s'] + files,
+        execute_command_verbose([libtool_exe, '-static', '-o', args.output] + files,
                                 cwd=temp_directory_root, verbose=args.verbose)
     else:
         execute_command_verbose([ar_exe, 'rcs', args.output] + files,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88449.294807.patch
Type: text/x-patch
Size: 633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200928/22189562/attachment.bin>