[libcxx-commits] [PATCH] D88421: Add a regression test for erasing from a vector

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

I'll add a second test along Michael's lines, if Louis doesn't beat me to it.
However, "using an arche type that counts the number of times it was moved from" would actually defeat the purpose of this regression test, as my regression happened only when erasing from a vector of trivially relocatable types that //don't// count the number of times they're moved from! So I saw the bug with vector<int> and vector<string>, but wouldn't see it with complicated, user-defined-move-constructor types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88421/new/

https://reviews.llvm.org/D88421