[libcxx-commits] [PATCH] D86540: [libcxxabi, libunwind] support running tests in standalone mode

[Dominik Montada via Phabricator via libcxx-commits]

gargaroff added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake:29
+
+# In a standalone build, we don't have llvm to automatically generate the
+# llvm-lit script for us.  So we need to provide an explicit directory that
----------------
ldionne wrote:
> I think it might be better to instead provide the `LLVM_LIT_OUTPUT_DIR` as a "parameter" of this module. Basically, set it before including it in various projects. WDYT?
Yeah sounds good. In that case it would also make sense to do the same for `{lib}_STANDALONE_BUILD`. That way we can completely remove the package name check from here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86540/new/

https://reviews.llvm.org/D86540