[libcxx-commits] [PATCH] D77786: [AArch64] Add v8.5 Branch Target Identification support.

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added inline comments.


================
Comment at: libunwind/src/assembly.h:51-63
+#if defined(__ARM_FEATURE_BTI_DEFAULT)
+  .pushsection ".note.gnu.property", "a" SEPARATOR                             \
+  .balign 8 SEPARATOR                                                          \
+  .long 4 SEPARATOR                                                            \
+  .long 0x10 SEPARATOR                                                         \
+  .long 0x5 SEPARATOR                                                          \
+  .asciz "GNU" SEPARATOR                                                       \
----------------
danielkiss wrote:
> I would drop this because it could be now replaced with a compiler flag `-mmark-bti-property` (D81930) 
adding the flag to only the assembly files would be huge change in the cmake files, so I revoke my idea to drop the note from here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77786/new/

https://reviews.llvm.org/D77786