[libcxx-commits] [PATCH] D62779: [2/2] Fix complexity of map insert_or_assign with a hint.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Sep 19 07:29:29 PDT 2020


Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!

In D62779#2279968 <https://reviews.llvm.org/D62779#2279968>, @ldionne wrote:

> LGTM, please:
>
> 2. Run: `for std in c++03 c++11 c++14 c++17 c++2a; do <build-dir>/bin/llvm-lit -sv libcxx/test/std/containers/associative/map --param std=$std; done` to make sure it all works

Thanks for this hint, clang tests al required C++ versions without overriding the std. It turns out the removed C++03 was required so I restored it before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62779/new/

https://reviews.llvm.org/D62779



More information about the libcxx-commits mailing list