[libcxx-commits] [PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

[Richard Smith - zygoloid via Phabricator via libcxx-commits]

rsmith added a comment.

The mechanism by which this interacts with Clang looks good to me. I've not done any detailed analysis to check all the functions made `constexpr` by P0784 are handled by this patch, though.



================
Comment at: libcxx/include/version:254
 // # define __cpp_lib_concepts                             201806L
+# define __cpp_lib_constexpr_dynamic_alloc              201907L
 // # define __cpp_lib_constexpr_misc                       201811L
----------------
Should this be conditioned on compiler support being available?


================
Comment at: libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/allocate_hint.pass.cpp:87
+#if TEST_STD_VER > 17
+    static_assert(test());
+#endif
----------------
I really like this approach to testing this change :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68364/new/

https://reviews.llvm.org/D68364