[libcxx-commits] [PATCH] D62779: [2/2] Fix complexity of map insert_or_assign with a hint.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 17 10:47:10 PDT 2020


Mordante updated this revision to Diff 292562.
Mordante marked an inline comment as done.
Mordante added a comment.

Improves the code based on @ldionne's suggestion

- `__emplace_hint_unique_key_args` returns a pair
- `insert_or_assign` uses `__emplace_hint_unique_key_args` internally
- removes the now unused code from the initial patch
- removes unused #ifdefs for `__emplace_hint_unique_key_args`, they seem a copy paste and the code isn't used for C++03


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62779/new/

https://reviews.llvm.org/D62779

Files:
  libcxx/include/__tree
  libcxx/include/map
  libcxx/test/std/containers/associative/map/map.modifiers/insert_or_assign.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62779.292562.patch
Type: text/x-patch
Size: 12331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200917/d44125ef/attachment-0001.bin>


More information about the libcxx-commits mailing list