[libcxx-commits] [PATCH] D86256: [libunwind] Make .eh_frame scanning/caching optional

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 14 17:31:28 PDT 2020


MaskRay added a comment.

In D86256#2272678 <https://reviews.llvm.org/D86256#2272678>, @rprichard wrote:

> Perhaps a more conservative fix for PR46829 is to match libgcc's behavior here, by disabling the end-of-section tracking for dl_iterate_phdr. e.g. by setting dwarf_section_length to -1. In that case, then PR36005's true fix is to link against a crtend.o with the .eh_frame terminator. (Or use LLD, which automatically inserts the terminator.)

Haven't read through the discussions. Just want to comment "Or use LLD, which automatically inserts the terminator" - the zero terminator CIE is to work around a glibc issue D46566 <https://reviews.llvm.org/D46566>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86256/new/

https://reviews.llvm.org/D86256



More information about the libcxx-commits mailing list