[libcxx-commits] [PATCH] D75795: [libc++abi] Change __cxa_finalize return type to void

[Louis Dionne via Phabricator via libcxx-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8bd0dc5bfe23: [libc++abi] Do not declare __cxa_finalize and __cxa_atexit in <cxxabi.h> (authored by ldionne).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75795/new/

https://reviews.llvm.org/D75795

Files:
  libcxxabi/include/cxxabi.h


Index: libcxxabi/include/cxxabi.h
===================================================================
--- libcxxabi/include/cxxabi.h
+++ libcxxabi/include/cxxabi.h
@@ -137,9 +137,9 @@
                 void (*destructor)(void *));
 
 // 3.3.5.3 Runtime API
-extern _LIBCXXABI_FUNC_VIS int __cxa_atexit(void (*f)(void *), void *p,
-                                            void *d);
-extern _LIBCXXABI_FUNC_VIS int __cxa_finalize(void *);
+// These functions are part of the C++ ABI, but they are not defined in libc++abi:
+//    int __cxa_atexit(void (*)(void *), void *, void *);
+//    void __cxa_finalize(void *);
 
 // 3.4 Demangler API
 extern _LIBCXXABI_FUNC_VIS char *__cxa_demangle(const char *mangled_name,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75795.291740.patch
Type: text/x-patch
Size: 718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200915/df2a6c5d/attachment-0001.bin>