[libcxx-commits] [libcxxabi] 8bd0dc5 - [libc++abi] Do not declare __cxa_finalize and __cxa_atexit in <cxxabi.h>

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-09-14T20:10:29-04:00
New Revision: 8bd0dc5bfe23fdfba110eefd33ff658289a307ab

URL: https://github.com/llvm/llvm-project/commit/8bd0dc5bfe23fdfba110eefd33ff658289a307ab
DIFF: https://github.com/llvm/llvm-project/commit/8bd0dc5bfe23fdfba110eefd33ff658289a307ab.diff

LOG: [libc++abi] Do not declare __cxa_finalize and __cxa_atexit in <cxxabi.h>

These functions are not defined by libc++abi, so they don't belong in <cxxabi.h>.

Differential Revision: https://reviews.llvm.org/D75795

Added: 
    

Modified: 
    libcxxabi/include/cxxabi.h

Removed: 
    


################################################################################
diff  --git a/libcxxabi/include/cxxabi.h b/libcxxabi/include/cxxabi.h
index 29e28a69a919..43ce6f5f740d 100644
--- a/libcxxabi/include/cxxabi.h
+++ b/libcxxabi/include/cxxabi.h
@@ -137,9 +137,9 @@ __cxa_vec_cctor(void *dest_array, void *src_array, size_t element_count,
                 void (*destructor)(void *));
 
 // 3.3.5.3 Runtime API
-extern _LIBCXXABI_FUNC_VIS int __cxa_atexit(void (*f)(void *), void *p,
-                                            void *d);
-extern _LIBCXXABI_FUNC_VIS int __cxa_finalize(void *);
+// These functions are part of the C++ ABI, but they are not defined in libc++abi:
+//    int __cxa_atexit(void (*)(void *), void *, void *);
+//    void __cxa_finalize(void *);
 
 // 3.4 Demangler API
 extern _LIBCXXABI_FUNC_VIS char *__cxa_demangle(const char *mangled_name,