[libcxx-commits] [PATCH] D86805: [lld-macho] create __TEXT, __unwind_info from __LD, __compact_unwind

[Greg McGary via Phabricator via libcxx-commits]

gkm updated this revision to Diff 291439.
gkm added a comment.

- Folding adjacent CU entries requires a vector with monotonically increasing `functionAddress`, and to get that we must first apply `std::sort()`.
- Abandon passing pageBreak 2nd compare arg via lambda-capture, because it is a fragile technique. It is only by an accident of the implementation that it works on `std::lower_bound`. It does not work for `std::upper_bound`, `std::binary_search`, or `std::equal_range`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86805/new/

https://reviews.llvm.org/D86805

Files:
  libunwind/include/mach-o/compact_unwind_encoding.h
  lld/MachO/CMakeLists.txt
  lld/MachO/OutputSegment.cpp
  lld/MachO/OutputSegment.h
  lld/MachO/SyntheticSections.h
  lld/MachO/UnwindInfo.cpp
  lld/MachO/UnwindInfo.h
  lld/MachO/Writer.cpp
  lld/test/MachO/compact-unwind.test
  lld/test/MachO/tools/generate-cfi-funcs.py
  lld/test/MachO/tools/validate-unwind-info.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86805.291439.patch
Type: text/x-patch
Size: 31622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200913/cdfa0d1b/attachment-0001.bin>