[libcxx-commits] [PATCH] D87508: [libcxx] Handle target triples with dashes in platform name
Mikhail Maltsev via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 11 04:47:03 PDT 2020
miyuki created this revision.
miyuki added a reviewer: ldionne.
Herald added subscribers: libcxx-commits, dexonsmith, kristof.beyls.
Herald added a project: libc++.
Herald added a reviewer: libc++.
miyuki requested review of this revision.
Target triples may contain a dash in the platform name (e.g.
"aarch64-arm-none-eabi"). Account for it when splitting the triple
into components.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87508
Files:
libcxx/utils/libcxx/test/config.py
Index: libcxx/utils/libcxx/test/config.py
===================================================================
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -245,7 +245,7 @@
# XFAIL markers for tests that are known to fail with versions of
# libc++ as were shipped with a particular triple.
if self.use_system_cxx_lib:
- (arch, vendor, platform) = self.config.target_triple.split('-')
+ (arch, vendor, platform) = self.config.target_triple.split('-', 2)
(sysname, version) = re.match(r'([^0-9]+)([0-9\.]*)', platform).groups()
self.config.available_features.add('with_system_cxx_lib={}-{}-{}{}'.format(arch, vendor, sysname, version))
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87508.291188.patch
Type: text/x-patch
Size: 746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200911/0142528c/attachment.bin>
More information about the libcxx-commits
mailing list