[libcxx-commits] [PATCH] D86805: [lld-macho] create __TEXT, __unwind_info from __LD, __compact_unwind

[Greg McGary via Phabricator via libcxx-commits]

gkm marked 5 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/UnwindInfo.cpp:90-92
+        if (targetIsec->getVA() == 0) {
+          error(Twine("__compact_unwind relocation is unresolved against " +
+                      targetIsec->segname + "," + targetIsec->name));
----------------
gkm wrote:
> smeenai wrote:
> > int3 wrote:
> > > Is this check really necessary? What kind of errors are we defending against? I would rather we not loop over the relocations unless necessary (for performance)
> > Yup. I don't have the full context here yet, but https://lld.llvm.org/NewLLD.html#numbers-you-want-to-know is relevant.
> This is an assertion--a sanity check on my own assumptions. Once I tested more widely, I will have no further use for it. A `TODO` comment to convey my intention is appropriate.
I am only looping over a subset of relocs, numbered 1+ per function. The "+" represents the subset of functions that have personality+lsda.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86805/new/

https://reviews.llvm.org/D86805