[libcxx-commits] [PATCH] D87323: Bring atomic header closer to C++20

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 8 13:01:05 PDT 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but please remove whitespace changes in `generate_feature_test_macro_components.py` if I read the diff right. We can do those separately and ignore that git rev when blaming.



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:90
    "headers": ["functional", "type_traits"]
-  },
+    },
   {"name": "__cpp_lib_is_final",
----------------
You seem to have whitespace changes here? Or am I reading the Phabricator diff wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87323/new/

https://reviews.llvm.org/D87323



More information about the libcxx-commits mailing list