[libcxx-commits] [PATCH] D86704: [libcxx] Add testing infrastructure for EXTERNAL_THREAD_API mode

Tue Sep 8 07:52:45 PDT 2020

Nicu added a comment.

In D86704#2242141 <https://reviews.llvm.org/D86704#2242141>, @ldionne wrote:

> I would like this and https://reviews.llvm.org/D86599 to be a single review, since I see those two as making the support for an external threading library official.

Merging of the both changes has been done.

@ldionne do you still think the change should be only modifying `libcxx/test`? As @miyuki mentioned, `__external_threading` is needed at build time so the main `CMakeList.txt` needs modification. In this case, the target `cxx-external-threads` which was previously working with `LIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY`, has been used for `LIBCXX_EXTERNAL_THREAD_API` so that the build logic is similar.

In the case you still want these modifications to be enclosed only under `libcxx/test`, do you have any suggestions or ideas for such an approach?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86704/new/

https://reviews.llvm.org/D86704