[libcxx-commits] [PATCH] D80558: Add constexpr to pair

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp:27
+  int moved = 0;
+  TEST_CONSTEXPR_CXX20 void reset() { copied = moved = 0; }
+  TEST_CONSTEXPR_CXX20 CountAssign() = default;
----------------
ldionne wrote:
> This isn't used.
True, will remove


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp:24
+    TEST_CONSTEXPR_CXX20 S(int j) : i(j) {}
     S * operator& () { assert(false); return this; }
     S const * operator& () const { assert(false); return this; }
----------------
ldionne wrote:
> miscco wrote:
> > Could we remove those by the way? I do not see any use for them
> Do you mean remove `S` altogether? It's used below.
I think that was from a previous revision where I did not yet removed those two lines

```
 S * operator& () { assert(false); return this; }
 S const * operator& () const { assert(false); return this; }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80558/new/

https://reviews.llvm.org/D80558