[libcxx-commits] [PATCH] D84677: [libunwind] Remove old keymgr related logic

Tue Sep 1 10:00:28 PDT 2020

ldionne added a comment.

In D84677#2249914 <https://reviews.llvm.org/D84677#2249914>, @vtjnash wrote:

> I'm glad to see this is gone. I was just about to file a bug report that this code used to incur a deadlock risk when unw_step was used from a signal handler since macOS 10.9.0 on x86_64, since Apple had removed the other side of this code circa keymgr-28, so it now had been attempting to call `malloc`. (I'd observed this deadlock occur in testing, and implemented a work around for it downstream, in https://github.com/JuliaLang/julia/pull/37101/commits/fad04d39d592d8e0fcbfba439e8157f582bbc850#diff-86a37833b03dbe7f0874e30469cb1d46R93-R102)

Yay for removing old cruft! :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84677/new/

https://reviews.llvm.org/D84677